Skip to content

feat: add memory profiling support #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
not-matthias wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: add memory profiling support #103

not-matthias wants to merge 4 commits into from

Conversation

@not-matthias
Copy link
Member

@not-matthias not-matthias commented Jan 28, 2026 •
edited
Loading

No description provided.

@not-matthias not-matthias force-pushed the cod-2105-support-memory-profiling-for-python branch from 55eeef1 to 4bd794f Compare January 28, 2026 17:51
@not-matthias not-matthias marked this pull request as ready for review January 28, 2026 17:51
@not-matthias not-matthias force-pushed the cod-2105-support-memory-profiling-for-python branch from 2351156 to c6a08d7 Compare January 28, 2026 17:59
@not-matthias not-matthias mentioned this pull request Jan 28, 2026
Merged
@avalanche-staging
Copy link

avalanche-staging bot commented Jan 28, 2026 •
edited
Loading

Congrats! CodSpeed is installed 🎉

🆕 330 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Open in CodSpeed

GuillaumeLagrange
GuillaumeLagrange approved these changes Jan 29, 2026
View reviewed changes
GuillaumeLagrange
GuillaumeLagrange requested changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant to request changes

Especially we need to validate the extra stack frame thing in instrumentation by comparing the output to a real prod run!

@not-matthias not-matthias force-pushed the cod-2105-support-memory-profiling-for-python branch from 1f5d7cf to e15aad8 Compare January 30, 2026 14:25
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 30, 2026 •
edited
Loading

Merging this PR will degrade performance by 28.43%

⚡ 12 improved benchmarks
❌ 15 (👁 15) regressed benchmarks
✅ 140 untouched benchmarks
🆕 110 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ WallTime test_pipe_communication[10000] 15.3 ms 14.9 ms +2.28%
⚡ WallTime test_multiprocessing_map[10000] 101.3 ms 89.8 ms +12.72%
👁 WallTime test_generate_all_combinations[5-4] 10.8 µs 11.1 µs -2.55%
⚡ WallTime test_fs_read[1000] 857.1 ns 770.4 ns +11.26%
⚡ WallTime test_hostname_resolution[google.com] 398.1 µs 385.3 µs +3.32%
👁 WallTime test_process_creation[cat /dev/null] 4.9 ms 5.3 ms -8%
👁 WallTime test_noop_pass 483.4 ns 504.1 ns -4.12%
👁 WallTime test_count_even[count_even_fast] 1.1 ms 1.3 ms -14.67%
👁 WallTime test_sum_of_squares[sum_of_squares_sum_labmda_product] 249.9 µs 282.6 µs -11.55%
👁 WallTime test_process_creation[echo hello] 2.2 ms 2.4 ms -8.24%
👁 WallTime test_array_alloc[100] 1.2 µs 1.3 µs -3.55%
👁 WallTime test_multiprocessing_map[100] 54.2 ms 60.4 ms -10.36%
⚡ WallTime test_minimax[scores0] 7.8 µs 7.5 µs +3.5%
👁 WallTime test_mmap_operation[40960] 46.8 µs 49 µs -4.47%
👁 WallTime test_pipe_communication[100] 7 ms 7.2 ms -2.83%
⚡ WallTime test_make_lowshelf 7.8 µs 7.6 µs +2.23%
👁 WallTime test_multiprocessing_map[100000] 192.2 ms 268.5 ms -28.43%
⚡ WallTime test_noop_pass_decorated 748 ns 686.4 ns +8.98%
⚡ WallTime test_solve_power_sum[13-2] 7 µs 6.7 µs +3.64%
⚡ WallTime test_sum_of_squares[sum_of_squares_sum_comprehension_power] 227.1 µs 217.9 µs +4.22%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Comparing cod-2105-support-memory-profiling-for-python (44487d4) with master (adee8a1)

Open in CodSpeed

@not-matthias not-matthias force-pushed the cod-2105-support-memory-profiling-for-python branch 2 times, most recently from 504d9a3 to 373acb4 Compare January 30, 2026 14:46
@not-matthias not-matthias force-pushed the cod-2105-support-memory-profiling-for-python branch 2 times, most recently from fc8f559 to 597bb2d Compare February 2, 2026 17:44
GuillaumeLagrange
GuillaumeLagrange approved these changes Feb 3, 2026
View reviewed changes
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeLagrange GuillaumeLagrange GuillaumeLagrange approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@not-matthias @GuillaumeLagrange